Matthias J. Sax

Results 145 comments of Matthias J. Sax

Thanks Bill. Made a pass. Can you also trigger a system test run and share the link?

I was just cycling back to the KIP. There is the following example: ``` // Old usage consumer.close(Duration.ofSeconds(30)); // New usage consumer.close(CloseOptions.timeout(Duration.ofSeconds(30)) .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)); // New usage (shorter version) consumer.close(CloseOptions.timeout(Duration.ofSeconds(30))); ```...

Oh sorry. I mixed up this work with the corresponding KS work... https://cwiki.apache.org/confluence/display/KAFKA/KIP-1153%3A+Refactor+Kafka+Streams+CloseOptions+to+Fluent+API+Style

High level comment: Is it wise to complete this PR before https://github.com/apache/kafka/pull/19955 ? -- It seems we should only remove the internal config, after we got the public API change...

Just talked to @bbejeck about this, and he will prioritize KIP-1153 to make sure we get is merged.

@abhi-ksolves -- What is the status of this PR? Are you still interested to finish it?

Seems to be an Kafka Streams limitation? Having said this, I _think_ KSQL could build a workaround by duplicating the data into a second topic under the hood. However, this...

@rmoff Thanks for creating the AK ticket. @Kaiserchen I left a comment on the AK ticket (partly copied below) that explains why I think KSQL cannot solve this issue itself:...

https://issues.apache.org/jira/browse/KAFKA-6687 might be useful for this case? We still should address https://issues.apache.org/jira/browse/KAFKA-7497 at some point, but maybe KAFKA-6687 is good enough to just unlock this feature while KAFKA-7497 would be...