Mitch Denny
Mitch Denny
Yeah its a typo. Thanks!
This is looking pretty good. Mostly just some minor things and questions. @eerhardt for a once over for the component side of things. I gave it a once over but...
One thing that I'm thinking about is allowing unauthenticated access to Attu?
Like @davidfowl said thanks for opening up the PR. I'm wondering whether we should model probes as a sub-field on the endpoint? The other thing to think about here is...
Now that we have `WaitFor` in which ties into health checks I think that there is a fairly clear path here now of how probes (especially readiness probes) might work...
Option 3 was basically your PR as it is now. Appreciate your perspective on this. I think it's pretty compelling. I'm leaning towards option 2 myself but interested in @davidfowl,...
Some API ideas: ```csharp var builder = DistributedApplication.CreateBuilder(args); var app = builder.AddProject(...); app.WithProbe(app.GetEndpoint("http"), "/health"); ``` Signature would look like: ```csharp public static IResourceBuilder WithProbe(this IResourceBuilder builder, EndpointReference endpoint, string path)...
@davidfowl @DamianEdwards confirming this is still in for GA ... if so, this would be a good one to jump on @JamesNK.
@wmeints primarily the issue with deprecating an extension is that it creates friction for those projects (that use it) to adopt newer versions of .NET Aspire. In practice though that...
@davidfowl @DamianEdwards @vhvb1989 @prom3theu5 Interested in your thoughts on the manifest structure here? We could introduce another field at the resource level for probes. But health probes are heavily correlated...