aspire icon indicating copy to clipboard operation
aspire copied to clipboard

Adds Milvus to the Aspire hosting/component packages

Open timheuer opened this issue 1 year ago • 4 comments

Adds the Milvus vector database to Aspire.

  • [x] Hosting component using container standalone
  • [x] Client component using C# Milvus.Client
  • [x] Hosting/Component initial tests
  • [x] Added playground app (use api.http to run the steps) - uses code samples from C# SDK
  • [x] Adds the Attu web admin experience (excluded from publish manifest)

Requires that a parameter exists for the root auth api key No healthchecks/tracing/metrics available in the C# Milvus.Client

https://github.com/dotnet/aspire/assets/4821/b763b107-b216-4202-965d-5d9dc8997b3f

/cc @roji @luisquintanilla

Microsoft Reviewers: Open in CodeFlow

timheuer avatar May 15 '24 00:05 timheuer

This is looking pretty good. Mostly just some minor things and questions. @eerhardt for a once over for the component side of things. I gave it a once over but he is more attuned to that side of things.

mitchdenny avatar May 15 '24 06:05 mitchdenny

One thing that I'm thinking about is allowing unauthenticated access to Attu?

mitchdenny avatar May 15 '24 06:05 mitchdenny

One thing that I'm thinking about is allowing unauthenticated access to Attu?

Attu requires authenticated access to the Milvus instance -- much like things like PgAdmin have a login prompt as well. Is that what you're referring to? Attu starts with a login requirement to an instance of Milvus, it isn't open-ended.

timheuer avatar May 15 '24 16:05 timheuer

Can you also add some end-to-end tests?

https://github.com/dotnet/aspire/blob/5f2af96cba6ee7764b36e38d7340e530bdb5cd66/tests/Aspire.EndToEnd.Tests/IntegrationServicesTests.cs#L26-L35

See https://github.com/dotnet/aspire/pull/3839 for an example.

eerhardt avatar May 17 '24 15:05 eerhardt

@eerhardt any other feedback to get this over the last mile?

timheuer avatar Jun 03 '24 23:06 timheuer