Mincong Lu
Mincong Lu
> The "compose" naming seems a bit confusing. But this looks like an "upsert" functionality? Where if it doesn't exist it updates instead? I don't think adding the method to...
> Now, maybe you are advocating that `compose` should straight up replace `insert`. And here, I think you might have a point. Like I've difficulties coming up with counterarguments why...
Update: Implemented `compose` on `Bundle`. This requires `Bundle` to be `Sized` and contains necessary usage of RPITIT, that bumps MSRV to 1.75.
Thought about this a little bit and alternative names could be either mathematical like `union`, `join` or something about synchronization like `sync_insert`. `par_insert` etc.
About `HashMap`, I suggest kill it completely and replace with `rustc_hash::FxHashMap`.
> Could you add an example demonstrating how one might use this? This seems like a really neat design, but making the jump from "cool API" to "practical use" has...
> Okay, that example was super useful! I now understand the point of this PR much better, and now it can be more easily taught and tested. > > I've...
> What exactly does being stringify! compatible mean? Asking, because I am working on eventual naga-oil/WGSL importing improvements. Mostly whitespace agnostic like rust and wgsl itself. I don't think this...
> Bone parents are not supported in gltf as far as I am aware I meant the blender parent type: bone, according to [#1292](https://github.com/KhronosGroup/glTF-Blender-IO/issues/1292).
I think `try_tick` is pretty useful to make an executor run statefully inside a non-async event loop like `winit`'s.