Thomas BERNARD

Results 253 comments of Thomas BERNARD

1. Yes indeed miniupnpd is not designed for such setup. I guess you can disable the LAN subnet match and see if it works... see https://github.com/miniupnp/miniupnp/blob/master/miniupnpd/minissdp.c#L1059 For security, we could...

about the permission rules for IPv6 #694

> Too many lines: 1904 (reference) vs 1905 (current). Please verify if there is an additional line that needs to be removed. I thought there was a missing blank line...

Currently, if asked for a UDP port mapping 54321 => 192.168.0.42:12345 the following pf rule is created : ``` pass in quick on $ext_if inet proto udp from any to...

So we must change ``` pass in quick on $ext_if inet proto udp from any to any port 54321 \ label "test label" rdr-to 192.168.0.42 port 12345 ``` to ```...

sorry for the break in a patch release.

> > sorry for the break in a patch release. > > No problem. This will be just running in handful of phones not in hotels or banks or airlines...

it looks related to the code of [`get_dnat_target()`](https://github.com/miniupnp/miniupnp/blob/master/miniupnpd/netfilter/iptcrdr.c#L105) which set to 0 the revision field of the `ipt_entry_target` (`xt_entry_target`) structure. I don't understand which revision we are supposed to set....

I just don't get what is the improvement. Also what do you mean by "[...] how most router projects actually use them." ? What are "most router projects" ?

the configuration option will be changed if "more and better" IGD compatibility modes are implemented. The name does describe what it does.