minio-cpp

minio-cpp copied to clipboard

balamurugana

Conflict between GetObject() vs GetObject macro in the windows headers (wingdi.h)

5

Here we continue to find errors with Windows. The meaning of `GetObject` is redifined inside the windows header wingdi.h ``` WINGDIAPI int WINAPI GetObjectA(__in HANDLE h, __in int c, __out_bcount_opt(c)...

noctaia

Fixes https://github.com/minio/minio-cpp/issues/134

kobalicek

Fixes #131

balamurugana

The GetPresignedObjectUrl() function has an error and does not return the correct value.

4

The expected signature generation is incomplete.

bboy-hui

fix DST setting properly in UtcTime

1

Fixes #132

balamurugana

There is still bunch of warnings regarding implicit conversion. Let's keep track of these: ``` minio-cpp/src/signer.cc:71:8: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion] 69 |...

kobalicek

without this change, urls like 5.my.s3.cluster were misinterpreted and the '5' parsed as the port of the url. Bug: * the getline() function puts the entire input string into the...

flokaiser

Replace the filename type of DownloadObjectArgs and UploadObjectArgs

10

Hi. I have a problem with the `filename` attribute type of `DownloadObjectArgs` and `UploadObjectArgs`. The current type is `std::string`, this leads to a file with utf-8 characters in the path...

z-pc

On Windows, UploadObject throws exception when trying to upload a binary file

2

The fix is to explicitly pass in std::ios::binary when opening the file stream. On Windows using a clang toolchain and libc++, trying to upload a binary file without the flag...

fwosar