minio-cpp icon indicating copy to clipboard operation
minio-cpp copied to clipboard

On Windows, UploadObject throws exception when trying to upload a binary file

Open fwosar opened this issue 1 year ago • 2 comments

The fix is to explicitly pass in std::ios::binary when opening the file stream. On Windows using a clang toolchain and libc++, trying to upload a binary file without the flag set will result in a rather cryptic exception:

libc++abi: terminating due to uncaught exception of type std::__1::ios_base::failure: ios_base::clear: unspecified iostream_category error

It may be a good idea to add some binary files to the automated tests instead of only text files as well. ;)

fwosar avatar Jun 21 '24 18:06 fwosar

@fwosar Feel free to send a PR

balamurugana avatar Jun 22 '24 00:06 balamurugana

If we are going to add binary files to tests I would like to have a generator of these files in our repository. Could be as simple as a python script, but please no binary files from users that can have encoded whatever data (hello xz utils).

kobalicek avatar Jun 24 '24 16:06 kobalicek

Thank you for helping me solve the problem!

Karmile avatar Dec 02 '24 09:12 Karmile