minio-cpp
minio-cpp copied to clipboard
On Windows, UploadObject throws exception when trying to upload a binary file
The fix is to explicitly pass in std::ios::binary when opening the file stream. On Windows using a clang toolchain and libc++, trying to upload a binary file without the flag set will result in a rather cryptic exception:
libc++abi: terminating due to uncaught exception of type std::__1::ios_base::failure: ios_base::clear: unspecified iostream_category error
It may be a good idea to add some binary files to the automated tests instead of only text files as well. ;)
@fwosar Feel free to send a PR
If we are going to add binary files to tests I would like to have a generator of these files in our repository. Could be as simple as a python script, but please no binary files from users that can have encoded whatever data (hello xz utils).
Thank you for helping me solve the problem!