Daniel Mendler comments

Results 795 comments of


                                            Daniel Mendler

Allow splat parsing to be disabled

I don't plan to merge this PR. At least not before the next release and not before I've done more investigation and resolved more pressing issues.

Incompatibilities with --enable-frozen-string-literal

If I understood correctly Ruby is moving to frozen literals by default? We should make this change slowly by adding `frozen_string_literal` headers to every file in Slim and Temple. PRs...

Incompatibilities with --enable-frozen-string-literal

Implemented in Temple and Slim. See https://github.com/slim-template/slim/commit/e1b66cc2a88a7244e5f3f057610a622e8c7ef0d0 and https://github.com/judofyr/temple/commit/0173e5e3d6fe9ea267db7be60c69f8ff13cbdb09. Please confirm that it works for you.

Intermittent test failures

Any new insight about this issue? It still seems to happen from time to time in the test suite.

Using slim to produce javascript templates escapes nested quotes

Slim seems to work as expected here. Escaping is performed by Tempel::Utils.escape_html. If desired this function can be overridden or configured.

Slim Render Class

Seems to be resolved by @thewatts' answer.

Class attributes using variables cause "useless use in void context" warnings

@kolen This issue has been fixed, right? Please reopen if that's not the case.

Defining ruby methods in template is no longer possible

Closing, see https://github.com/rtomayko/tilt/issues/347#issuecomment-1204460147

Problem with slim template, but it works fine in erb

It seems this has been resolved since #841 was merged?

Issue with implicit `to_s`

I believe this has been fixed now in Temple. See https://github.com/judofyr/temple/pull/126