Mike Whit

Results 13 comments of Mike Whit
trafficstars

I see that you are relying on the symmetric nature of the algorithm. Also, per the examples, sometimes a conversion to a hex string helped me when wrapping the Node...

``` encrypt(data) { const iv = this.initializationVector(); const cipher = this.crypto.createCipheriv(this.algorithm, this.key, iv); let encrypted = new Buffer(iv).toString('base64') + cipher.update(data, 'utf8', 'base64') + cipher.final('base64'); this.hmac = this.crypto.createHmac('sha512', this.key) .update(encrypted).digest('hex'); return...

IIRC base64 may be what Node prefers but I don't exactly recall. There may also be padding-related issues since the aes-js library seems to indicate fragility around fixed length keys.

I added some notes on adapting Express.js to HTTP2 or to reevaluate the SPDY breakages.. Add this one to the list It seems more reliable in the interim to suggest...

CC @QuantGeekDev I pulled in changes from #3390 today and you have to run his test suite via ```HTTP2_TEST npm test``` which fails. it might be useful if we start...

understandable @wesleytodd i would have assumed as much.. FWIW we discussed yesterday (people in this issue ticket) "why http2": in general this is the summary: * HTTP2 reports benchmark gains...

i would not mind contributing to create a separate version of express that works with HTTP2, backwards compatibility be damned. i would also not mind authoring the change if we...

Yeah, well, a startup I consulted for ran out of cash in December and I need a job :) But no, I also want to see this happen. The last...

See PR : https://github.com/expressjs/express/pull/3730 I can pick up where this one left off (6 years ago!).. speed in Express is important to me.

Yes let's chat @QuantGeekDev i added you in LI