Michael Dawson-Haggerty
Michael Dawson-Haggerty
Hey, yeah `cap: bool` is not implemented for non-complete revolves, PR's welcome! `cap` is supported for `sweep` which I'd probably look at [for reference](https://github.com/mikedh/trimesh/blob/e4106737e2a3572dbd68248f877be0937f54f91b/trimesh/creation.py#L213-L254).
Hey, actually connected components are used a lot for some reason, and the existing implementation supports and benchmarks multiple graph backends (networkx and scipy.sparse.csgraph): https://github.com/mikedh/trimesh/blob/2fcb2b2ea8085d253e692ecd4f71b8f450890d51/trimesh/graph.py#L376-L476 If you were looking at...
Hey yeah agreed that seems like it would be pretty easy and would make sense to be bidirectional, it's just not implemented. PR's with a fix and test would be...
Yeah perhaps the docstring should be clearer, is the situation here is "there are N faces sharing an edge where N > 2"? I.e. the mesh is not watertight/manifold/etc? Maybe...
Hey, is it possible it's the difference between binary and ASCII STL exports? ``` In [9]: m = trimesh.creation.icosphere() In [10]: len(m.export(file_type='stl_ascii')) Out[10]: 371039 In [11]: len(m.export(file_type='stl')) Out[11]: 64084 ```
Great thanks! I think you need to fork the repo through the Github interface and then PR from there. The procedure is usually: - fork the repo using the "fork"...
Do the [test_ray.py](https://github.com/mikedh/trimesh/blob/master/tests/test_ray.py) tests pass for you? If you have a reproducable example happy to take PR's adding tests that fail haha, maybe an `trimesh.creation.icosphere` with a bunch of ray-hits?...
Also probably the thread to keep an eye on is here: https://github.com/mikedh/trimesh/pull/1108
Does https://github.com/mikedh/trimesh/pull/2298 help at all? PR's welcome! One thing that might help breaking this in the future is if we added a test that tried the debian build, which I...
> The Debian build system requires that all dependencies must be available in the Debian ecosystem. It looked like trimesh wasn't testing with blender at all (good catch!) so I...