Markus Hoffrogge

@zlobniyshurik many thanks for letting us know about this issue. What is the operating system you are hosting DokuWiki on?

@zlobniyshurik this issue is root caused by the `escapeshellarg($message)` in `Git.php` function `commit(...)`. This is to be fixed. I'd prefer to persist the `$message` in a temporary binary file and...

@woolfg - It was tested on recent DokuWiki Release 2020-07-29 “Hogfather”.

@woolfg - Did fix the PHP 7.3 incompatibility issue and made some improvements to the default config.

> After installing the update, this line is causing an error: > > ``` > 2021-12-23 17:14:02: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Parse error: syntax error, unexpected '?', expecting function (T_FUNCTION) or...

@sjv0 @woolfg In my dokuwiki configs I did configure repoPath and repoWorkDir the same. To be honest I did not yet get fully how a scenario with repoWorkDir being different...

@sjv0 many thanks for the details of your config. Stupid question: Did you let the repoPath .git config know about the worktree - by using the `git worktree add ...`...

Hi @sjv0, many thanks for that clarification. This was also my assumption for your use case. So there is a lot of confusion around this git work tree feature. And...

> If you were going to omit the `--work-tree` argument, wouldn't you still need to at least provide `-C repoPath`? @sjv0 This will work, since each git command is performed...

Yes @woolfg, this is correct. None of the "Optional:" marked configuration properties must be set. If those are left empty, then anything works as before. So it is backward compatible...