Marcin Pietruszka

Results 17 comments of Marcin Pietruszka

@gkaran is it solved? I did it manually with `topOffset` and `stickyStyle` props

Should cropping leading/trailing whitespace (in both modes % and auto) also belong here? https://docs.google.com/presentation/d/1ZiZWrmLiX40rt3n_1LMSGJxYWI-xsWFsS9bkzdbRIV8/edit?ts=5ec3ef17#slide=id.g7830109f71_0_105 Edit: it is now in the new epic https://github.com/google/web-stories-wp/issues/3532

We also use this ⏹️ icon in other places, should we fix it everywhere? (Issue updated) ![image](https://user-images.githubusercontent.com/21036224/153884911-fd53dc28-92bd-4cf3-b25a-fedb50454d3a.png) Back in the days, it was ⏸️ : ![image](https://user-images.githubusercontent.com/21036224/153884980-2dcc26dd-9c9d-45fd-89ee-61997b246268.png)

Looks good, but UX-wise: without the video, I wouldn't notice the "Toggle element toolbar" button - let's talk about it on the design sync.

Summary of the latest updates: You will see two `useMediaRecorder` instances in the code: `mediaRecorder` and `canvasRecorder`. When all effects are disabled (default state) we will do the recording in...

> Still seeing the permissions popup in firefox. What happens when you select the first camera again? What happens after you refresh the page and select the first/second camera? That...

> The dialog seems a little confusing. Why don't any of the dropdown have label / legend to explain what these are. Depending on the name of your webcam, it...

> Still not seeing this functionality working in safari. Yep, Safari is tricky (when fetching frames from the canvas), still testing.

> Noticed another weird issues with the settings dialog. See video. > > Screen.Recording.2022-09-13.at.11.14.03.mov What browser is this? any errors in the console?

> Seeing slow down of image in safari. That is expected. It will never match the native blur or get close to it, tho it looks better on my Macbook...