sudo-rs

sudo-rs copied to clipboard

Add CI only tests

2

This resolves issue #708. Any test that requires being run on the CI server is marked with ```#[ignore = ci]```. I added ```-- --ignored``` to both the miri and build-and-test...

oneElectron

Tests assume daemon is uid 1

4

``` ---- system::tests::test_get_user_and_group_by_id stdout ---- thread 'system::tests::test_get_user_and_group_by_id' panicked at 'assertion failed: `(left == right)` left: `"bin"`, right: `"daemon"`', src/system/mod.rs:666:13 ``` This is an error that I get when I run...

oneElectron

sudoers: accept the `list` keyword in command position

1

example ``` console ALL ALL=(ALL:ALL) list ``` the `list` keyword refers to the `sudo --list` command.

japaric

relevant test https://github.com/memorysafety/sudo-rs/blob/719fcfe24401e7d71ec029ec799428702ae47a0e/test-framework/sudo-compliance-tests/src/sudoers/env_keep.rs#L344-L360 the observed ogsudo behavior is that the key-value syntax needs double quotes to work, that is `env_keep = "KEY=value"` triggers the key-value match semantics but `env_keep =...

japaric

relevant test https://github.com/memorysafety/sudo-rs/blob/719fcfe24401e7d71ec029ec799428702ae47a0e/test-framework/sudo-compliance-tests/src/sudoers/env_keep.rs#L369-L384 ogsudo removes env vars that start with `()` even if they appear *by name* in `env_keep`. the prevent the removal of such env vars the parentheses-glob variant...

japaric

`-U` and `-u` flags are different. The [manual](https://www.sudo.ws/docs/man/sudo.man/#U) states: > [`-U`](https://www.sudo.ws/docs/man/sudo.man/#U) user, `--other-user`=user > Used in conjunction with the `-l` option to list the privileges for _user_ instead of for...

BriocheBerlin

Test `use_pty`

1

**Describe the feature you'd like see implemented in `sudo-rs`** We should test the `use_pty` behavior **What problem can be solved with this feature?** In principle, you could fork a background...

pvdrz

Similar to https://github.com/memorysafety/sudo-rs/issues/439 https://github.com/memorysafety/sudo-rs/issues/558 needs to be solved first. From the [documentation](https://www.sudo.ws/docs/man/sudoers.man/#Tag_Spec): ``` By default, if the NOPASSWD tag is applied to any of a user's entries for the current...

BriocheBerlin

code cov was disabled because we have been observing spurious failures in the llvm runtime that introduced warning / error messages in sudo's stderr. PR that disabled code cov: https://github.com/memorysafety/sudo-rs/pull/659

japaric

This issue tracks if `sudo-rs` behaves the same as ogsudo when receiving certain signals: - [x] SIGALRM: Tracked by #448 - [x] SIGCHLD: This is indirectly tested by the fact...

pvdrz