sudo-rs

sudo-rs copied to clipboard

Remove log and pretty-assertions dependencies

1

The log crate wasn't used for getting logs from dependencies and we only used a small subset of the functionality of the log crate, so removing it simplifies things. The...

bjorn3

Fix the problem by throwing an error if the number is negative or unexpected, added a test too. This is a suggestion only. Thread: https://github.com/trifectatechfoundation/sudo-rs/issues/1311

Pingasmaster

Change the default so that asterisks are shown when entering passwords. It is still possibly to disable the asterisks by explicitly turning `pwfeedback` off. This fixes a major UX pain...

Timmmm

This pull request replaces `system::time::Duration` with `std::time::Duration`. I couldn't find any code that still uses negative duration, so I replaced it with it's `std` equivalent. The only place, where I'm...

joriskleiber

I decided to go with the existing loop style as the `wildcard_match` function for continuity, simplicity, and index control. With this draft I have a few questions: 1. Can I...

noahboa27

test failure during Fedora build of 0.2.9: common::context::tests::test_build_run_context

5

I'm working on updating sudo-rs Fedora package to the latest version, and I encountered one new test failure in 0.2.9 (compared to 0.2.6) - from the build log: ``` failures:...

decathorpe

visudo: unable to find editor

2

I have the following in root's .bashrc alias vim='TERM=xterm-color vim' export EDITOR=vim Calling visudo-rs complains that it can't find the editor and refuses to start. Commenting out the first of...

hyder365

test_traverse_secure_open_positive() makes assumptions about current directory

5

The test `test_traverse_secure_open_positive()` at https://github.com/trifectatechfoundation/sudo-rs/blob/main/src/system/audit.rs#L359 makes assumptions about the current directory and its parents. These don't hold in Debian's CI, which runs `cargo test` from outside the (read-only) directory containing...

Fabian-Gruenbichler

Malicious or misconfigured PAM module can DOS sudo-rs via num_msg=-1

2

PAM modules can send a `num_msg`, which is handled improperly by `sudo-rs`, as it is assumed this is a positive number without any checks. Negative PAM message counts cause integer...

Pingasmaster

Support !syslog

3

**Describe the feature you'd like see implemented in `sudo-rs`** I'd like to be able to use the `!syslog` option from `sudo`. **What problem can be solved with this feature?** I...

grifferz