Mohammed BOUKHALFA
Mohammed BOUKHALFA
/label lang/ar
@arezk84 Did you notice the error message on the Changed Files tab ?
> Hi @mboukhalfa. I noticed this PR contains some changes I believe you intended for #46043. Will you please rebase and post some screenshot previews? I was expecting to get...
> Thanks @mboukhalfa! I am not an HTML expert, but I noticed the language switcher could render better: > >  > > Quite...
This PR is just to preview the changes and see the results with RTL lang (ar) the CSS changes will directly target the main branch once satisfied
> I'd prefer to pass the [`dir`](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/dir) for the HTML based on the text direction property of each language. Then it should work much better. > > This will need...
> Let's build on that. Can we make the customisations only apply using the cascade when `dir` is `rtl`? (We can pair you up with someone who knows SCSS to...
> Let's build on that. Can we make the customisations only apply using the cascade when `dir` is `rtl`? (We can pair you up with someone who knows SCSS to...
> As drafted, this change makes the top nav not look right in narrow viewports for LTR locales. I'd really like to see something that doesn't regress (partially break) our...