Max Jones
Max Jones
That makes sense, thanks for the explanation and sharing the link to the code.
Thanks for working to improve PyGMT based on your experiences with the library. I agree that adding the full expectation for column order when a filename is given would be...
> Did we want to also use YAML configured issue forms for feature requests or any of the other items under https://github.com/GenericMappingTools/pygmt/issues/new/choose? I generally prefer the rendering of the YAML...
I like how GMT.jl handles clipping through the coast module (https://www.generic-mapping-tools.org/GMT.jl/dev/#GMT.coast) using a `clip` parameter that controls both starting and ending clip paths. In Python form, `clip="land"` starts clip path...
> > Just a note regarding comment number 1 - the clip path applies to **all** plotting calls between the start of the clip path and the end of a...
> > Just a note regarding comment number 1 - the clip path applies to all plotting calls between the start of the clip path and the end of a...
> Totally agree with you @meghanrjones, should be bundled together. How should we continue with this PR? I recommend leaving it as is briefly until we find out whether GMT...
> I saw the corresponding GMT PR was merged with only a fix in the docs @maxrjones. Do you think we can continue here? Yes, continuing sounds good. Here's how...
I agree with raising a warning rather than an error for most non-supported versions. However, we should raise an error if the version is truly not compatible (e.g., GMT 5).
> @GenericMappingTools/pygmt-maintainers This PR has been untouched since August; are we planning to get it wrapped up for v0.5.0? I think the issues raised in https://github.com/GenericMappingTools/pygmt/pull/923#pullrequestreview-737713277 will be a bit...