Max Jones

Results 225 comments of Max Jones

I've started using pre-commit while working on some other repositories and find it really nice. If there turns out to be interest from others in this tool, I could help...

> Is it worth trying https://pre-commit.ci/? Yes, I think we could try this as an alternative to the [format slash command](https://github.com/GenericMappingTools/pygmt/blob/main/.github/workflows/format-command.yml) and probably the [style checks workflow](https://github.com/GenericMappingTools/pygmt/blob/main/.github/workflows/style_checks.yaml).

I'm not sure how easy it would be to create a simpler example from this, but `@GCMT_1976-2017_meca.gmt` contains focal mechanism data and is used in https://docs.generic-mapping-tools.org/latest/animations/anim14.html

> Wanted to add also examples for multi-band bars. However, so far I couldn't figure out how it works. Maybe @meghanrjones can help me out 😉. Is this what you're...

xref https://github.com/GenericMappingTools/gmt/issues/5563 - I think we're leaning towards fill for GMT, but PyGMT already has color in plot and plot3d.

I prefer that we don't indefinitely support multiple aliases. The `deprecate_parameter` decorator is already designed to allow two parameter names, only temporarily with a warning. My preferred path forward would...

I think that the aliases that do not follow this convention were added to PyGMT before the convention was established. For context, the idea of a convention to ensure consistency...

Hi @sixy6e, I'm checking in to see whether you're interested in continuing work on this PR, prefer to pass the PR to someone else, or rather abandon the PR for...

I'll add alt text to /content/tutorial-style-guide.md

I agree that we should still have a way to test whether the published script produces the same output, but I am less convinced that we should test that on...