Max Bachmann

Results 300 comments of Max Bachmann
trafficstars

The project uses a complete copy of GPL licensed code from `fuzzywuzzy` and `python-Levenshtein`. See e.g. https://github.com/willowtreeapps/fuzzywuzzy-kotlin/blob/64f9d3c409d6808024297dc7258edcc87793a7d8/app/src/commonMain/kotlin/com/willowtreeapps/fuzzywuzzy/diffutils/DiffUtils.kt#L21-L108 https://github.com/ztane/python-Levenshtein/blob/07785f1516ea099ded127bceea71b5fa41147306/Levenshtein/_levenshtein.c#L5775-L5838 so publishing + using this project under the Apache license is a...

So this would mean, that on installation failure a hook is called, which would allow me to handle the error? This would be awesome. I currently handle this using try/except...

One thing that could lead to problems is the `cmake`/`ninja` dependency, because as far as I know there is no notion of `try to install` for dependencies in Python. So...

An alternative I thought of when I was working on this for `rapidfuzz` was an `optional_cmake` package. This package would do the same as the `cmake` package, but on failure...

Hm so if I understand you correctly: `wheel.cmake = False` would 1) try to install cmake/ninja. Probably based on whether it is already installed / a wheel is available. 2)...

Thanks for the clarification. Yes I completely misunderstood which part this was going to solve.

might make sense to combine this with https://github.com/project-alice-assistant/ProjectAliceSkills/tree/master/PublishedSkills/maxbachmann/Speedtest to create a ultimate skill to test how bad your internet is

This can be handled using https://github.com/project-alice-assistant/ProjectAlice/pull/133 in the future

@haakenlid is there still interest in this? otherwise feel free to close this PR.