ProjectAliceSkills icon indicating copy to clipboard operation
ProjectAliceSkills copied to clipboard

grammar mistakes in answers

Open maxbachmann opened this issue 6 years ago • 3 comments

in the skill Alice Satellite there is for example the training example ```what is the temperature {outside:=>Room}`` the answer is: "It is currently {1} degrees in the {0}", This has two problems:

  1. when the room is for example outside, the answer sentence should be it is currently 5 degrees outside and not is is currently 5 degrees in the outside
  2. when the temperature is a singular (1 degree or -1 degree) the answer should include degree instead of degrees

The same issue probably appears in other places aswell. So there should be another option to the current random.talk function to set language specific behavior and pluralise functions to get the grammar stuff right.

Might make sence to use: https://docs.python.org/3/library/gettext.html, since it is highly different between languages when the singular and when the plural is used

maxbachmann avatar Aug 09 '19 00:08 maxbachmann

Be carefull with alice satellite. Many things, like the temperature, are gone. Telemetry module is due to overtake it all

Psychokiller1888 avatar Oct 05 '19 04:10 Psychokiller1888

ok

maxbachmann avatar Oct 05 '19 22:10 maxbachmann

This can be handled using https://github.com/project-alice-assistant/ProjectAlice/pull/133 in the future

maxbachmann avatar Dec 09 '19 06:12 maxbachmann