Maximilian Roos

Results 1175 comments of Maximilian Roos

I do think it's both goals — similar to the two I listed above. I'm happy to handwrite the SQL — do we have a view of what the "best"...

I definitely agree better SQL formatting would be helpful, and #1284 is a good issue for that... But I would have thought that PRQL's needs are _mostly_ the same as...

Thanks @YuxiLing , I added this to https://github.com/shssoichiro/sqlformat-rs/issues/22.

Yes I think this makes sense, and would be quite easy — maybe as easy as adding it to https://github.com/PRQL/prql/blob/04b5174cba01bcc79837e69f0697486210d3d6dd/crates/prql-compiler/src/ir/pl/extra/expr.rs#L112-L118 and catching any places where that's matched against...

> It looks depending on sqlparser crate [here](https://github.com/PRQL/prql/blob/main/prqlc/prqlc/src/sql/gen_query.rs#L344). So does it mean need to add support in sqlparser crate first? Coming back to this issue — this is correct... I...

FYI this is now released upstream! So could be a reasonable contribution to PRQL https://github.com/sqlparser-rs/sqlparser-rs/pull/1288

Great, these are good! (I renamed to make it a bit clearer. Though I appreciate the "wat" reference!)

Yes, I think this is valid, and we should keep this open — it would be a nicer result if `b` were used instead of `_expr_0`. And it's a very...

I think for doc comments — which specifically refer to the item below them — we could make a guess. ``` #! a comment on sample_albums let sample_albums = (...

No but I'm reasonably close to having half of it working — to be able to parse into our AST. So watch this space...