prql icon indicating copy to clipboard operation
prql copied to clipboard

Published 20 hours ago • verified publisher icon PRQL

support for ASOF joins

Open era127 opened this issue 2 years ago • 4 comments

What's up?

I am starting to look at PRQL and I was wondering if there is the possibility to support ASOF joins such as in duckdb I understand this type of support is not in standard sql but It would help to have it translated.

era127 avatar Aug 24 '23 17:08 era127

Yes I think this makes sense, and would be quite easy — maybe as easy as adding it to https://github.com/PRQL/prql/blob/04b5174cba01bcc79837e69f0697486210d3d6dd/crates/prql-compiler/src/ir/pl/extra/expr.rs#L112-L118 and catching any places where that's matched against...

max-sixty avatar Aug 24 '23 18:08 max-sixty

It looks depending on sqlparser crate here. So does it mean need to add support in sqlparser crate first?

xueyumusic avatar Mar 31 '24 06:03 xueyumusic

It looks depending on sqlparser crate here. So does it mean need to add support in sqlparser crate first?

Coming back to this issue — this is correct... I think that would likely be a welcome contribution for them, and not that much code...

max-sixty avatar May 19 '24 18:05 max-sixty

FYI this is now released upstream! So could be a reasonable contribution to PRQL

https://github.com/sqlparser-rs/sqlparser-rs/pull/1288

max-sixty avatar Jun 03 '24 17:06 max-sixty