Maximilian Roos

Yes good points. I think we can merge given those votes, we'd need some big negatives to not do this... Re the formatting — yes, the color scheme, and the...

> I'll take a quick stab at unifying the styles a bit more before merging. OK great! TBC, I didn't mean we had to bundle them. Great if you're up...

@mklopets shall we hit the button?

Great, thank you @mklopets !

Yes that sounds very reasonable. An alternative (no view on which is better) is that we use types, and type the window functions which support frames vs those that don't....

> I believe this is not dialect dependent, but some dialects just treat it as an error and some ignore it. This was also my understanding, from https://github.com/prql/prql/issues/1069#issuecomment-1344867546. So agree...

It's a good question; I also use `LIKE` given its simplicity. It's not that extensible, unlike regex, so one option is to exclusively use regex; https://github.com/prql/prql/issues/562 But regex is not...

I agree this is quite confusing and I had to take a few minutes to work out what was going on. I think we want: ```diff - func like fld...

> What bad thing would happen if someone wrote `func like fld str -> s'{fld} like "%{str}%"'` and PRQL never added `'` around the string, and produced `bar like "%stuff%"`...

Ah, actually this issue is about the language feature, not the s-string question, reopening