Max Nicholson

Results 10 comments of Max Nicholson

Also having this issue. Although we're using a custom 3rd party IDP instead of Facebook, our custom policy was built from this sample/snippet.

I think the solution is to modify this line: https://github.com/achillesrasquinha/pipupgrade/blob/1ec3d5fd779fd8aff008be1fe2ec72888a8cd494/src/pipupgrade/model/package.py#L86 `package.req.specifier` is a `frozenset` of `Specifier` classes (https://github.com/pypa/pip/blob/31eb524ff0d18d6190b30a0c7821c0c857a7523c/src/pip/_vendor/packaging/specifiers.py#L334) So in this case the current version would be `list(package.req.specifier)[0].version -> "24.0.0"`...

Noticed while looking at this that [https://github.com/achillesrasquinha/pipupgrade/blob/1ec3d5fd779fd8aff008be1fe2ec72888a8cd494/src/pipupgrade/commands/helper.py#L265](here), when we get the final list of packages to show the user in the interactive window, the `packages` list gets reassigned (so the...

Came across this error myself with pipupgrade v1.8.2 and pip v20.3.3. The `package` arg of the Package class __init__ seems to be of type [ParsedRequirement](https://github.com/pypa/pip/blob/a387de10d81ca0688c7cd267be6054efeca89e94/src/pip/_internal/req/req_file.py#L84) as of pip v20.X, so...

Getting the same on the latest firefox version (113)

@mikeynap did you end up having a go at this? I've taken a look, and it does look like a good chunk of the Github code could be re-usable, but...

👍 . Had started a couple of weeks back, and admittedly hadn't got far - https://github.com/VirtusLab/git-machete/compare/master...max-nicholson:git-machete:add-gitlab Looks like you've already gone beyond what I'd already done. Let me know how...

The first thing that seemed quite different to Github (and wasn't sure how to reconcile) was the `OrganizationAndRepository` interface/config. Gitlab instead has a concept of "Namespaces" and "Projects". A "Project"...

I've just pushed to my fork branch the remaining WIP changes I had - mostly around the `Namespace` / `Project` I mentioned above + starting on a generic API Client....

Hi @marco-saia-datadog, yes that's correct. The main gotcha with the current behaviour is that you need nested key dotpaths (e.g. "error.name", "error.customProperty") vs. simply converting the `Error` instance to a...