Matt Wang

Results 380 comments of Matt Wang

Hm. Let me see if I can do some rebasing and force-pushing to fix this.

Okay, I've committed the cardinal sin of force-pushing after an interactive rebase. I have: - removed all the commits that you made about the TOC - the initial commit, the...

> So I assume I should create a fresh PR branch, based main. I'll start on it in about 30 minutes. Yup! And no rush!

> But my local clone(s) appear to be messed up: after merging in the current main from JtD, GH Desktop wants to push 9 local commits to GitHub… You may...

Thanks for the very detailed write-up @kevinlin1! I agree that the use-case is definitely valid, and I appreciate you enumerating several different reasons why this may be helpful. I do...

Thanks for chiming in @JPrevost and @kevinlin1! Just to make sure I'm understanding: - @JPrevost you're asking for most of the contents of `_layouts/default.html` to be broken up into includable...

Oh - just realizing I never responded in-thread. I think Kevin's on vacation, but his proposed suggestion is definitely doable. I think it's a quick addition to the two bullet...

Thanks for offering @JPrevost - now that it is close to late next week, realizing that I don't have too much time. Since it's Sep 28, I doubt that I'll...

Hi @Teddy-van-Jerry, thanks for submitting an issue. I'm a bit confused what the request is - overriding the `_includes/title.html` like you've done _is_ the way to have a title logo...

Oh, gotcha - coming back to this now. Hm, what are you envisioning for a configuration option? I'm wary of just adding a path since in these cases, CSS +...