Matt Johnson-Pint

Results 434 comments of Matt Johnson-Pint
trafficstars

@srutzky - Thanks! I'll try to carve out some time to look this over soon, and also at Maggie's suggestions in #14. Hang in there. :)

And while wrapping the above will _work_, it could probably be written better as a single lookup against the `Interval` table.

I'm almost done simplifying the API even further, and then yes - i will put a sample application together. Thanks.

I haven't documented all the quirks of the different logon types, as I simply pass them along to Windows. I agree that much more could be said about each one....

No problem. Keep in mind that SQL 2016 will support Windows time zones natively, so you may not actually need this if you can upgrade. Still, will do at some...

I'll work on added support for them soon, and will have a flag to the import utility to control whether you want IANA, Microsoft, or both.

In what case might a NULL be passed explicitly? I see what this is guarding against, but I'm not sure it would actually be encountered. What I'd really like is...

For .NET we are addressing in https://github.com/getsentry/sentry-dotnet/pull/1996 We needed to choose a transaction status for these failed transactions. Since the unhandled exception is interrupting the transaction, we went with `aborted`.

I haven't updated the spec yet. Thanks for the reminder. In TSC it was said that this behavior wasn't applicable for JS. I also mentioned status `aborted` in TSC without...