Matthias Rampke

Results 248 comments of Matthias Rampke

To make the tests pass with Go 1.16 reliably, I had to relax the timing requirements a fair bit; I hope that's acceptable.

This form doesn't work because we can only decide whether to log _after_ a request has been handled. The middleware needs to be in the call path so that it...

@telendt like this?

Damn! When this happens, are there scrape errors? What does the exporter's `/metrics` endpoint look like when it's working and when not? Does it log anything? What does it log...

> How can I tell if there are scrape errors? On the Prometheus server, the `up` metric for this target at this time would go to `0`. There is additional...

The error happens at scrape time, so the exporter main doesn't have access to the error. Logging from within the library would be good but I don't know what a...

This likely happened before but was silently handled (in an undefined way) by the client library. We came from an ancient version, and it has grown a lot more validations...

Yes, that's the semantics of the exporter and Prometheus. It's a little more complex in real Graphite because one of them could come with an older timestamp but we don't...

I don't think keeping persistent metric instances around is the best way. It fixes the issue incidentally because it forces us to dedup, but we can also dedup and then...

I don't understand why a longer expiry helps?