Matthew Olsson

Results 17 comments of Matthew Olsson

I used milliseconds in the timer API because it mirrors every other API that deals with timers (Kotlin timers, JS's `setInterval`/`setTimeout`, etc). I can change it to float for consistency.

Two issues from looking at the implementation of `Entity::rayTrace`: 1. It looks like it only returns blocks. If this is the case, then the method should be renamed to reflect...

That wasn't clear to me since the cascade functions return `ErrorOr`. Turns out, it's all because of this one little allocation 😅: https://github.com/SerenityOS/serenity/blob/c1dbde72e963a3ed6e930b8e8e6a45c848dbb193/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp#L744 #23471 is related; The type of a...

> Doesn't quite close the Duolingo issue, we still hit the reCaptcha timeout Figured 👍 wasn't sure since it does fix the unsupported message

> My tab here had a comment about giving parse_v4_crypt a return type instead of two out params. I've done that, but now that I try to reply to that...

> This feature would also allow us to play the animation on https://beta.strawberry.rocks/ that follows the cursor. Looks like this will require some work on interpolation as well, specifically with...

Note for anyone who might have already looked at this: I pulled what used to be the first commit here (update `DocumentTimeline`'s origin time) into #23198 since it was blocking...

@ADKaster I think the only issue left here is that I currently get this when running `./Meta/serenity.sh build x86_64 Clang` with `ENABLE_CLANG_PLUGINS=ON`: ``` [181/184] Linking CXX shared library lib/liblagom-idl.so.0.0.0 [182/184]...

> Looks like this still needs a little love before it can build on CI 😅 Well it passes CI now (red CI is unrelated I believe), though the plugins...