Daniel Arndt

Results 790 comments of Daniel Arndt

Let's see what everyone else is thinking about this.

> Set AllowPointerConditions to true and revert these changes I knew that you didn't like it so it was always true. I don't know why it complained about that one...

@crtrott I addressed your comments.

> IMO, all the casting to bool for things like enum : bool { accessible = ... }; are bad changes. They can/will be fixed with C++17 and inline static...

> I'd prefer the latter I'm not surprised. :slightly_smiling_face:

@dalg24 I simply replaced the relevant unnamed enums with `static constexpr bool` in [`4eafd28` (#4648)](https://github.com/kokkos/kokkos/pull/4648/commits/4eafd28ef5f1a0dc3bf590c38afd504e556f5dad). Even without requiring C++17 that should be fine as long as they are not ODR-used...

The diff is best viewed without whitespace changes.