Daniel Arndt comments

Results 778 comments of


                                            Daniel Arndt

Avoid instantiating default constructor of value type when WithoutInitializing is given

Retest this please.

Avoid instantiating default constructor of value type when WithoutInitializing is given

> Just guard that thing in the ViewArray version too then I approve. The clang stuff we should look at independently. See https://github.com/kokkos/kokkos/pull/5307/commits/3f3bbc2ec0680d6707dca986197beb737ff5f953.

Avoid instantiating default constructor of value type when WithoutInitializing is given

Retest this please.

Avoid instantiating default constructor of value type when WithoutInitializing is given

Only `KokkosCore_UnitTest_CudaTimingBased` is failing in `CUDA-11.6-NVHPC`.

Try using FindOpenMP instead of figuring out flags manually

Retest this please.

Try using FindOpenMP instead of figuring out flags manually

Retest this please.

Try using FindOpenMP instead of figuring out flags manually

This pull currently doesn't add any linker flags but passes our regular CI. It would be good to check this on a somewhat wider ranger of configurations.

Try using FindOpenMP instead of figuring out flags manually

I think the interesting cases to test with are `CLANG_CRAY` and `CLANG_MSVC`.

Try using FindOpenMP instead of figuring out flags manually

I almost forgot that I can check myself for clang_cray. On `spock`, I get ``` -- Setting default Kokkos CXX standard to 14 -- The CXX compiler identification is Clang...

Try using FindOpenMP instead of figuring out flags manually

> @masterleinad is that still WIP? Or does this work now? I didn't change anything but I would think that the error in https://github.com/kokkos/kokkos/pull/4105#issuecomment-881727991 is more an issue with the...