Daniel Arndt

Results 805 comments of Daniel Arndt

The only errors in Cuda builds are ``` var/jenkins/workspace/Kokkos_PR-7021/core/unit_test/TestTeamMDRangePolicyCTAD.cpp(76): error #177-D: function "::TestTeamThreadMDRangeCTAD::test_ctad_inside_parallel_for" was declared but never referenced /var/jenkins/workspace/Kokkos_PR-7021/core/unit_test/TestTeamMDRangePolicyCTAD.cpp(136): error #177-D: function "::TestTeamVectorMDRangeCTAD::test_ctad_inside_parallel_for" was declared but never referenced /var/jenkins/workspace/Kokkos_PR-7021/core/unit_test/TestTeamMDRangePolicyCTAD.cpp(196): error...

Rebased after #7049 was merged.

Only `'HIP-ROCm-5.6-C++20'` is failing.

> These fixes look fine, however, questions remain about more (potentially) complicated fixes for warnings associated with methods in `TestStdAlgorithmsCommon.hpp` that appear in CUDA-11.2.x compilations -- do we want to...

> Please discuss node availability considerations. As far as I know we have preview access, no blanket promise about long-term availability of the GPU. Also, restricting a build to run...

Let's close until we have (permanent? reliable?) access to that node.

This pull request should not change the minimum CMake version (which would be a breaking change and there are other places that should be consistent). Rather something like ```diff diff...

```diff diff --git a/cmake/kokkos_tribits.cmake b/cmake/kokkos_tribits.cmake index 3ebf775fa..cfc7db252 100644 --- a/cmake/kokkos_tribits.cmake +++ b/cmake/kokkos_tribits.cmake @@ -490,15 +490,11 @@ ENDFUNCTION() FUNCTION(KOKKOS_LIB_INCLUDE_DIRECTORIES TARGET) - IF(KOKKOS_HAS_TRILINOS) - #ignore the target, tribits doesn't do anything directly...

> @masterleinad that change should be generally safe? I wasn't bold enough to try that before putting in this PR, but that is definitely preferred Yes, `Trilinos` should have switched...