Daniel Arndt comments

Results 805 comments of


                                            Daniel Arndt

OpenACC: Skip exec_space_thread_safety_range_scan

The OpenACC build passed.

SYCL: Skip launch_six Graph test

> @masterleinad I didn't see this before posting #7025 , but I'm also seeing the segfault on PVC I can confirm and updated this pull request accordingly. I don't understand...

SYCL: Skip launch_six Graph test

Testing manually I'm seeing ``` $ make -j8 Kokkos_CoreUnitTest_SYCL1A && ./core/unit_test/Kokkos_CoreUnitTest_SYCL1A --gtest_filter="*graph*" [ 11%] Built target kokkossimd [ 11%] Built target kokkos_gtest [ 44%] Built target kokkoscore [ 44%] Built...

SYCL: Don't use shuffles for top-level reductions

The SYCL build passed.

Failing Kokkos::SYCL Unit Tests

What do the results look like if you explicitly provide the target architecture?

Failing Kokkos::SYCL Unit Tests

> With `-DKokkos_ARCH_INTEL_GEN=ON` - This flag seems to help a lot but I would have assumed that JIT is default. Not sure what Kokkos tries to do when this flag...

Failing Kokkos::SYCL Unit Tests

> [LastTest-DDKokkos_ARCH_INTEL_GEN.txt](https://github.com/kokkos/kokkos/files/15301815/LastTest-DDKokkos_ARCH_INTEL_GEN.txt) The list of failing tests is: > [ FAILED ] serial.atomic_operations_double (0 ms) [ FAILED ] serial.atomic_operations_float (0 ms) [ FAILED ] 2 tests, listed below: [ FAILED...

SYCL: Fix deprecation in custom parallel_for RangePolicy implementation

The SYCL build passed.

SYCL: Fix deprecation in custom parallel_for RangePolicy implementation

> What about the other occurrence in that file L29? The launch mechanism for that one is using `sycl::range` and not `sycl::nd_range`.

Several warnings in cuda builds

```diff diff --git a/core/unit_test/TestArray.cpp b/core/unit_test/TestArray.cpp index 11b28bed9..c2c8510d8 100644 --- a/core/unit_test/TestArray.cpp +++ b/core/unit_test/TestArray.cpp @@ -132,7 +132,7 @@ struct MyInt { int i; private: - friend constexpr void kokkos_swap(MyInt& lhs, MyInt& rhs)...