Daniel Arndt

Results 791 comments of Daniel Arndt

Seeing ``` [100%] Linking CXX shared library libkokkoscontainers.so cd /app/kokkos/build/containers/src && /opt/cmake/bin/cmake -E cmake_link_script CMakeFiles/kokkoscontainers.dir/link.txt --verbose=1 /opt/rocm/bin/hipcc -fPIC -O2 -g -DNDEBUG -DKOKKOS_DEPENDENCE -fgpu-rdc --offload-arch=gfx90a -shared -Wl,-soname,libkokkoscontainers.so.4.2 -o libkokkoscontainers.so.4.2.99 CMakeFiles/kokkoscontainers.dir/impl/Kokkos_UnorderedMap_impl.cpp.o -Wl,-rpath,/app/kokkos/build/core/src:...

> That is true. We can create some valid (non-overlapping) cases with layout stride views, which do not satisfy this check. If there is a way to check that in...

You'll have to rebase on top of `develop`.

> Functor has `init()` and `join()` defined Only `join` is required. We fall back to the default constructor for `init` if the reducer/functor doesn't implement it.

> Kokkos release or commit used (i.e., the sha1 number): Version 3.7.02 Is there a reason for using such an old version? What are your linker flags? What exactly do...

> @masterleinad it seems to have been removed? Ah, yes, needed to update my local `develop` branch.

I would assume it doesn't break `Sacado`/`Stokhos` but we should follow up with them.

```C++ #include #include #include #include #include // When the special members are defined, we get the following error //#define HIDE_SPECIAL_MEMBERS // User-defined comparator we don't have control over, that does...

It's actually not stride(1) but stride(2) that fails: https://godbolt.org/z/14q5o136r