Daniel Arndt
We should be able to just record the compiler output manually and grep for "warning: ". That's certainly not perfect but should work as a workaround.
> What mechanism do you suggest? ADL? I was literally thinking about storing the primitives (or a reference/pointer to them) in the constructor of the tree. AFAICT, that requires adding...
> The problem is reproducible on Ascent. However, no code tweaking been successful so far. ```diff diff --git a/src/ArborX_LinearBVH.hpp b/src/ArborX_LinearBVH.hpp index 23a1a32a..5fc3c3be 100644 --- a/src/ArborX_LinearBVH.hpp +++ b/src/ArborX_LinearBVH.hpp @@ -145,7 +145,8...
If neither the reducer nor the functor implements `init()`, `init()` is implemented as placement new value initialization (which is pretty much what we were trying to achieve with the specialization)....
Sure, we need `reduction_identity` if using `Kokkos::Sum`. I mainly don't like having code we never exercise in our tests, examples, or benchmarks. What about just using `Kokkos::Sum` instead of a...
I am seeing ``` error: linking module '/opt/sycl/lib/clang/14.0.0/../../clc/remangled-l64-signed_char.libspirv-nvptx64--nvidiacl.bc': Linking two modules of different target triples: '/opt/sycl/lib/clang/14.0.0/../../clc/remangled-l64-signed_char.libspirv-nvptx64--nvidiacl.bc' is 'nvptx64-unknown-nvidiacl' whereas '/tmp/ArborX/test/tstBoostGeometryAdapters.cpp' is 'nvptx64-nvidia-cuda' [-Werror,-Wlinker-warnings] ``` at least.
> Ah, you are right. I think that's coming from the install build, as you would also need to update the `post` section. I'm trying to argue more in the...
Yes, I understand that this project doesn't want to use `-Werror`. I just try to say that the warning checker should detect all warnings just as `-Werror` is supposed to....
If this breaks too many projects, we could, of course, include `ReductionIdentity.hpp` in `Kokkos_NumericTraits.hpp` again.
https://github.com/kokkos/kokkos/pull/5146 should fix this.