Daniel Arndt

Results 776 comments of Daniel Arndt

Also, remember that you need a `*.output` file for a new test to be picked up.

@mayrmt How much success have you had using `Tpetra` with `deal.II`? IIRC we don't have support for `Tpetra` matrices yet.

> For `Node`, is there a default that corresponds to just CPU without any additional parallelization or offloading? `Kokkos::Compat::KokkosSerialWrapperNode`

If most of the implementation is copied from `compute_nonzero_normal_flux_constraints`, I would very much prefer to find a common version than to duplicate ~450 LOC. Also, how did you verify that...

Would you mind writing a pull request for fixing this if you already have the changes locally?

You could use sycl::ext::oneapi::experimental::printf of course, e.g., https://github.com/kokkos/kokkos/blob/63ceaca62813248e4b2eae3fab742b3028206168/core/src/setup/Kokkos_Setup_SYCL.hpp#L59-L65.

Yes, I know. First want to figure out why this didn't quite work as expected.

> Also, this PR tries to do too many things simultaneously, and should be split in multiple, like the part touching the core (with the addition of unit testing) and...

> I'm deeply confused about the purpose of this PR and its relationship to XGC. In my understanding, XGC would require calling tree traversal individually from each thread, with no...

> And `Kokkos::Profiling::ProfilingSection` being copyable and assignable looks like a bug. I agree. Ar you fixing it?