Philippe Marschall

Results 166 comments of Philippe Marschall

The source distribution builds fail because whatever does the source transformation is buggy. It converts @EnsuresNonNullIf(expression = "lowerBound", result = false) into /* @EnsuresNonNull */If(expression = "lowerBound", result = false)...

I fixed all the failures and cleaned up the code a bit more (reduced duplications). It is again ready for review. I had a look at implementing date/ts/tstzrange: * The...

Which part of Hibernate would blow up? I'm certainly no expert when I comes to Hibernate but 5.2 and later require [Java 8 and JDBC 4.2](http://hibernate.org/orm/documentation/getting-started/). Why naÏve assumption was...

I ran some basic tests with Hibernate 5.2 and they all worked. I tested mapping `TIMESTAMP WITH TIME ZONE` to `java.sql.Timestamp` and mapping `java.sql.Timestamp` using an attribute converter. If you...

I will ask if there is a way to do this.

@davecramer the PR is written so that's it's only active for JDBC 4.2. An other option would be to use the new strict timestamps configuration option.

@bheemreddy181 it's not my call, if you would like to see it merged it may help if you state your needs

Could somebody review this and provide feedback?

If you want me to break up the PR or change anything else let me know.

I understand the concern for breaking existing applications. However there is also an other side and that is new applications and code. For them the driver does not "just work"....