Philippe Marschall
Philippe Marschall
@alexanderkjall thanks Regarding `OffsetDateTime` what I meant supporting `OffsetDateTime` for `TIMESTAMP WITH TIME ZONE` the same way `ResultSet#getObject` and `PreparedStatement#setObject` do. Until #695 is fixed `TIMESTAMP WITH TIME ZONE` is...
@alexanderkjall `OffsetDateTime` for `TIMESTAMP WITH TIME ZONE` is already supported by `ResultSet#getObject` and `PreparedStatement#setObject` so supporting it in `ResultSet#updateObject` would make that consistent.
@alexanderkjall the current UTC behavior is consistent with `ResultSet#getObject` and `PreparedStatement#setObject`. You could try storing with an offset other than UTC and asserting you get the same instant back but...
I’ll be able to have a look at it again in one or two days
Can you tell me what would have to be changed in order to get this merged?
I believe I implemented all the requested changes. The only thing I didn't do was the parameterization of the tests because I don't think it's a good fit. Let me...
Currently `LogicalReplicationTest#testDuringSendBigTransactionConnectionCloseSlotStatusNotActive` is failing, it's not obvious to me how this is related to my changes.
I fixed the merge conflicts and implemented all requested changes. Is there anything preventing this from being merged?
@vlsi @davecramer sorry for bothering you again, if and when do you believe this PR can be merged? I believe this is a low risk change.
How can I help to get this reviewed and merged?