Mark McDonald

Results 93 comments of Mark McDonald
trafficstars

High level comment here is that this is great content. Well written, clear, easy to follow and shows off something technically impressive. You're welcome to add a by-line or link...

Do you need to push your changes? I can see you've responded but it doesn't look like content has changed since [Aug 16](https://github.com/google-gemini/cookbook/pull/76/commits)

Just a couple of last little comments. I've updated your branch to get most of the checks passing - nbfmt, nblint, etc. We require a copyright header at the top...

> Not sure what I did here, "dismissed markmcd’s stale review via [23e2ad3](https://github.com/google-gemini/cookbook/commit/23e2ad370e913a6abe6270175a92dd2cf668da4b)" but hopefully that didn't break anything. 😄 Nothing wrong on your end! That's our GitHub setup. Re-approved...

Are you able to convert this into a IPython notebook? You can use the template we have [here](https://github.com/google-gemini/cookbook/blob/main/templates/Template.ipynb).

Thanks for the contribution. Before we do a deep review, we have a few questions about the content. It might be easier to create a new issue where we can...

> https://developers.google.com/mediapipe/api/solutions/python/mp/tasks/vision/holistic_landmarker/image_processing_options_module/ImageProcessingOptions shows that `ImageProcessingOptions` is in `mediapipe.tasks.vision.holistic_landmarker.image_processing_options_module` but this package does not exist. I have no idea where this class is exported from. If you take the fully-qualified class...

There are a couple of ways you can proxy with the SDK. You can force the SDK to use HTTP traffic (it's gRPC by default) with `genai.configure(..., transport="rest")`, then the...

> Are you saying that I can now use `genai.configure` to configure a reverse proxy for the Gemini API? It's not built _specifically_ for reverse proxying, we use it for...

This looks like @shilpakancharla. I've invited her to the org to resolve the issue. Please accept, Shilpa :)