cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Generate personalized product descriptions using the Gemini API and Weaviate

Open erika-shorten opened this issue 1 year ago • 6 comments
trafficstars

Hi there,

Here is a demo using Weaviate and the Gemini API to generate personalized product descriptions! I've added two files:

  1. The notebook
  2. YAML file to run Weaviate locally

Thank you! 🙂

erika-shorten avatar Apr 17 '24 17:04 erika-shorten

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 17 '24 17:04 google-cla[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Hi @MarkDaoust, are there any changes required to merge this notebook? Thank you. 🙂

erika-shorten avatar Jun 05 '24 17:06 erika-shorten

Hey @erika-cardenas - sorry I haven't got to this sooner. Is this something you're still keen on publishing (I hope so - it'd be a great contribution)?

If so, a couple of quick requests for you - can you move this to live in examples/weaviate/...? can you refer to the product as the Gemini API (not Gemini - that's the chatbot)? and can you review the feedback in the notebook lint check too (it will include things like using 2nd person - i.e. "you" not "we")? If you want to proceed I'll go through in more detail but at a high level the idea is great and I'm keen to have it in the collection.

If not, that's OK, just let me know, or don't, and this will auto-clean up in a couple weeks.

markmcd avatar Aug 15 '24 08:08 markmcd

Hi Mark,

Thanks so much for your feedback! It would be great to publish this notebook, and I am working on the changes now. 🙂

erika-shorten avatar Aug 15 '24 19:08 erika-shorten

High level comment here is that this is great content. Well written, clear, easy to follow and shows off something technically impressive. You're welcome to add a by-line or link out to your GitHub or a social profile if you want too.

I've left a bunch of comments, mostly little nits, overall it's in great shape already.

Thanks again.

markmcd avatar Aug 16 '24 08:08 markmcd

Do you need to push your changes? I can see you've responded but it doesn't look like content has changed since Aug 16

markmcd avatar Aug 27 '24 09:08 markmcd

Hey @markmcd, thank you for the feedback, I'm still working through a few. I was out of the office all last week so I'm catching up with work now. I will have all the edits done today and commit my changes!

erika-shorten avatar Aug 27 '24 12:08 erika-shorten

Hey @markmcd, I just finished the edits! I appreciate the kind words for the notebook and for providing a thorough review. Please let me know if anything else is needed from my side. 🙂

erika-shorten avatar Aug 27 '24 18:08 erika-shorten

Just a couple of last little comments. I've updated your branch to get most of the checks passing - nbfmt, nblint, etc. We require a copyright header at the top of the notebook, as you've signed the CLA, you are welcome to append to, or replace the copyright line to include your own copyright as appropriate (e.g. personally if you are allowed, or as your company if they own the IP).

The remaining GitHub check failures are false positives - the README one is referring to the docker file, which we can ignore, and the nblint is referring to first-person language, which AFAICT is where you refer to "us" in your bio section, which is fine.

markmcd avatar Aug 28 '24 09:08 markmcd

Amazing! I've made a few additional changes and made sure it works end-to-end in Colab!

Not sure what I did here, "dismissed markmcd’s stale review via 23e2ad3" but hopefully that didn't break anything. 😄

erika-shorten avatar Aug 28 '24 14:08 erika-shorten

Not sure what I did here, "dismissed markmcd’s stale review via 23e2ad3" but hopefully that didn't break anything. 😄

Nothing wrong on your end! That's our GitHub setup. Re-approved and will merge now. Thanks again for the contribution!

markmcd avatar Sep 02 '24 09:09 markmcd