Results 209 comments of João Marcos
trafficstars

I don't have a simple example but [this is the code](https://github.com/marcospb19/mini-c/blob/6c371fceb36a81a03d1a0f2b44d89713db8cde29/components/mini-c-lexer/src/lib.rs#L10-L11) I was messing with. My _Parser_ crate depends on my _Lexer_ crate, so the _Lexer_ crate can't access `CustomParseError`...

@Pat-Lafon :O oops, can you try again? _(this comment will self-destruct soon)_

Tests are failing so I'm assuming this is a draft not ready for reviewing yet.

I believe you have to change the theme code itself, yes.

I'd expect the #59 fix to require a major version update, it's not obvious to users whether that's a bug or intended behavior, so that should be assumed as breaking...

Knowing "idiomatic Rust" is a subjective concept, feel free to close this if you don't see benefit in it. I believe it is important to have the examples without it...

I didn't include changes like this: ```rust // From if let Some(ref mut dac) = maybe_dac { // To if let Some(dac) = &mut maybe_dac { ``` That replace `ref...

> as I explained the common convention for assert statements is putting actual before expected Out of curiosity, are there any Rust libraries that do this? I mean, although this...

Hey @leninberg, have you solved this problem? i think this issue should be closed if so

> I also run a leaderboard using TrueSkill calculations and the way I revert matches there is to store the ratings and deviations before the game happened in a database...