Results 209 comments of João Marcos
trafficstars

~~@LilithHafner I made some comments on the PR that adds `glidesort` regarding how you're doing measurements, and how that probably benefits `Julia`'s algorithm~~. EDIT: I was wrong, Julia really seems...

Conditions act as filters, I wonder what's the most intuitive behavior, between `&&` and `||` for chaining filters. In other words, should a project pass on `every` or `any` condition/filter?...

Some technical details for someone who wants to pick this: I suggest you move contents from `main` to a new `run` function, and execute it from `main`, then use the...

@jyn514 but we can't return `anyhow::Error` in `main`, because we are using `error!` to report our errors and not `Debug`. Why call `error!` for each error instead of having the...

> I guess standardizing on `error!` instead of `main` is fine By `main` you mean `Err` returning on `main`, right? My suggestion of wrapping stuff around a `run` function is...

I found some https://github.com/holmgr/cargo-sweep/blob/507575643ff344cfd0326a8d13ec0b6836f16fda/src/main.rs#L187-L190

That would be bad if you're not using `--recursive`. ``` # Please sweep on current directory $ cargo sweep --installed ``` I'd expect some output to be shown with some...

True! Thanks. GitHub tip: you can add "Fixes #NNN" or "Fix #NNN" to automatically close the referred issue with the PR merge :wink:.

@aminya by chance, do you recall the command you used?

That's funny because I don't use Rust Analyzer, but thanks!