Manu Garg

Results 119 comments of Manu Garg

Gave more thought to single run interface at the binary level and below: ### Interface - Binary Flags: —single_mode, —count - Current flow is `cmd/cloudprober → cloudprober.Start → prober.Start →...

Probe's run interface will look like this: ``` Probe { Init(name string, opts *options.Options) error Start(ctx context.Context, dataChan chan *metrics.EventMetrics) Run(ctx context.Context) (bool, []byte, error) // successOrFail, json-formatted metrics, error...

I think final result format is going to be interesting here. Do we return metrics in the end, or just success/fail and perhaps overall duration? Or maybe both? We can...

One of the usage of this functionality could be to run cloudprober to verify a deployment. It may be useful to extend this functionality with things like: - Wait for...

Added first draft of single run interface in #1081.

Starting with: https://github.com/cloudprober/cloudprober/pull/888

https://github.com/cloudprober/cloudprober/pull/936 adds more tests.

I think there are enough tests to close this ticket now. Rest we'll add as we go.

Sounds reasonable to me. It should be easy to implement as well.

Hey @conallob, Are you using an old version by any chance? Above commands work on my system. Support for include was added in https://github.com/cloudprober/cloudprober/releases/tag/v0.13.2.