Manu Garg

Results 119 comments of Manu Garg

I am guessing page title is useful primarily on the all notes page?

@rajiv-mittal I don't follow. Line breaks should work already. Can you please share the screenshot of the issue you're encountering.

This restriction was actually a deliberate decision. Thinking was that editing notes through the current mobile web interface will be really annoying and will likely lead to bad user experience....

Funny thing, I recently closed an old issue for the same because of lack of demand: 😄 https://github.com/cloudprober/cloudprober/issues/8

Just wanted to add that consul targets implementation should still happen through RDS -- basically add a new RDS provider similar to `file`, `kubernetes`, and `gcp`. Implementation will look similar...

We should sanitize label values within browser probe reporter as well, e.g. https://github.com/cloudprober/cloudprober/blob/d8d43a19b338a490f17a29ee6b868f83ef4998f3/probes/browser/templates/cloudprober-reporter.ts.tmpl#L54-L55 for example, a test title -- "do x, then y", will end up being parsed as {test=""do...

https://github.com/cloudprober/cloudprober/pull/976 fixes the underlying line parsing problem.

Note that after #976 merge, it should be less of an issue. Labels are generated in one of the following ways: 1. Added by us: probe, dst, etc. 2. Configured...

Since the main problem is fixed, it's really hard to get tripped by it. Marking it as enhancement.

For certain probe types it will be more difficult to support single run interface, e.g. PING, UDP, but for others, e.g. HTTP, DNS, GRPC, TCP, EXTERNAL, it should be doable....