mango

[WeOpen Star]I would like to help

WeOpen Star I'd like to work on this issue.

Hi @tao12345666333 . On the implementation, I want to confirm a few things: 1. We should add `sni` in types. https://github.com/apache/apisix-ingress-controller/blob/3cccd5666e098f374c262eb443de194d69d6a55e/pkg/types/apisix/v1/types.go#L331-L339 2. When `ApisixRoute` translate to `StreamRoute`, we should add...

> I prefer `Host` But seems `ApisixRouteSpec.Stream` doesn't have this property? If I'm missed the meaning, please correct me, thanks.

I have been commit a PR #1051, if you have free time, please have a review~

Sure, I'd like to work on it.

> @mangoGoForward Please make the CI pass, thanks! See https://github.com/apache/apisix-ingress-controller/runs/6623221714?check_suite_focus=true. I got some `connection refused` errors, this feature seems wouldn't effect the CI?

> Please also add some e2e test cases to cover the SNI route feature. Thanks, I will do.

Hi @tokers How can I generate a `crd`? The `Makefile` seems has no related command.

> Please merge master latest code, and resolve conflicts. Thanks OK. I will solve it later.