Cheerful Ottering
Cheerful Ottering
another samilar issue is https://github.com/crabml/crabml/blob/db55e53884a4740e0cd68e208c0ec4b3892bc97b/crabml-core/src/cpu/buf/buf_q8_0.rs#L155 The issue is in vec_dot_q8_0_q8_0_neon where it processes blocks in pairs without checking if abs has enough elements: ``` for i in (0..blocks_rounded).step_by(2) { let...
Ok, but I am busy working on my thesis recently and may not be able to create a pr fix soon, and in the meantime, if someone else is willing...
I am not sure whether it is true. But maybe we should take a look at it :)
Thank you for your thoughtful response and explanation of the use of unsafe in bytes_to_cstring. While I understand and appreciate your argument about the performance benefits of unsafe and its...
In my opinion, at the very least, this function should be marked as `unsafe` and include clear documentation outlining the safety preconditions required for its use. Alternatively, if these preconditions...
oh, sorry i don't notice TB is no longer maintaining. It seems like we can just discuss it.
Another bug maybe https://github.com/tensorbase/tensorbase/blob/7b071a88a175da64e5c8cca7f1710940fe9b75ab/crates/runtime/src/write.rs#L275 I noitce there maybe invalid utf8 data flow from `pub fn write_block -> fn write_part` which may result in UB. I understand that this project may...
same for https://github.com/tensorbase/tensorbase/blob/7b071a88a175da64e5c8cca7f1710940fe9b75ab/crates/runtime/src/write.rs#L81 from `pub fn write_block -> fn gen_parts_by_ptk_names` AND https://github.com/tensorbase/tensorbase/blob/7b071a88a175da64e5c8cca7f1710940fe9b75ab/crates/runtime/src/write.rs#L366 from `pub fn write_block -> fn write_part_locked`
Hello again, I think maybe current fix is not sufficient :( because I notice the following function: https://github.com/DioxusLabs/blitz/blob/017f8ea722df16411a8d53fd340f32cd26bbd585/packages/blitz-dom/src/node.rs#L97 the user can still pass a Null pointer through the `new` method...
Thanks, I will keep search if there are other cases. If I found, I will report it in this issue.