Cheerful Ottering

Results 58 comments of Cheerful Ottering

Thanks for your reply. If is this case maybe define it in other crate and declear it as pub(crate) is more appropriate, it can avoid other potential unsafe usage with...

same problem for https://github.com/Starlight-JS/starlight/blob/503e789b9ef53594aee30c45a621018e855dcc17/crates/starlight/src/interpreter/stack.rs#L71

https://github.com/Andy-Python-Programmer/aero/blob/c5f81142d8996044730436349d3b005bbb0b9b9e/src/aero_kernel/src/acpi/rsdp.rs#L134 same problem

same problem for LongsPtr::longs https://github.com/zhihu/rucene/blob/5b55f842c2bb03beb96898d520e880c180c91adf/src/core/util/ints_ref.rs#L215

maybe same for https://github.com/zhihu/rucene/blob/5b55f842c2bb03beb96898d520e880c180c91adf/src/core/util/disi.rs#L32 although it checked the ptr is not null, any invalid pointer can still trigger UB.

Thanks for your quick response, you are right that this is not a serious problem. I also noticed this code because I was testing my static scanning tool to look...

same to https://github.com/servo/mozjs/blob/e299b24d2d48e451a47994d7ad1283ea56ed653d/mozjs/src/gc/root.rs#L22