Luke Dashjr
Luke Dashjr
Concept NACK, I think? Isn't this used by libbitcoin and/or btcd??
Concept ~0, but I object the claim in general that commits "sufficiently buried by other commits, and thus less likely to be reverted". Git isn't PoW, and "burying" commits does...
See also https://github.com/bitcoin-core/gui/issues/750
`checkChainLimits` should probably get a warning-only-for-wallet-use comment too
The CI failures appear to have been because CFeeRate(0) needed to be special-cased as "no limit" also. Fixed that. Rebased on top of #28471, partially by reverting its first commit...
> I don’t think adding a new vsize-based total package limit is necessary, the existing ancestor size limits are sufficient. Ok, dropping that (and the revert) then.
The current PR doesn't make sense to me. It's treating a height as a time? But no block would have a time before a height... So this just adds calculations...
Rebased and added some fixes
>Can you add steps to reproduce the bug? Run `./configure` and watch the output