Luke Dashjr
Luke Dashjr
Maybe add a functional test that would have failed too?
Concept NACK, I think. Wallet encryption is not going to help you if someone steals your wallet, only if someone gains very temporary access to your keyboard/mouse only. I don't...
It makes a minor difference of reporting the correct version number. I agree with @hebasto on using the tag, but also agree with @fanquake on not having a policy that...
Weak Concept NACK: We should probably still build the SSE4.1 code if the compiler supports it. The flag should only affect the rest of the codebase, so that the software...
Would be better to score the peers rather than choose one at random.
7e90b5938f4dbdba58355f55f785c9054055a912 has a typo in the commit message
>History of this config option suggests datacarriersize is meant to limit the size of data in OP_RETURN outputs, so this statement is untrue. It's meant to limit extra data in...
No, it doesn't contradict it. That overview conveniently leaves out the context of OP_RETURN being the _only_ way tolerated, and the `datacarriersize` limit makes no sense the way you want...
Does dropping 2 lose the test that we haven't broken the serialization format somehow? Maybe it should be comparing a fixed mapping of some values at least?