Lorenz Walthert

Results 539 comments of Lorenz Walthert

See the template history here: https://github.com/lorenzwalthert/precommit/commits/main/inst/pre-commit-gha.yaml. I guess the problem with the {renv} cache was that the actual cache is not kept (or some files needed to restore it), but...

Thanks for the idea @joelnitta. The thing is that I try to keep the depenency graph of {precommit} light, and {V8} as a recursive dependency does not meet this criteria...

You can run pre-commit hooks from the pre-commit framework with other hooks alongside in the so-called migration mode, so there should be no compatibility issue.

I think so. Please consult upstream docs at pre-commit.com.

> I am not sure how this would work if I wanted to add another pre-commit hook outside of the precommit framework, but it works for this particular case (precommit...

> Also @lorenzwalthert do you mind explaining why having the option to include the ccfr pre-commit hook would add cffr's dependencies? Short anser: If it's merely a check for outdated...

I think `~/.cache/pre-commit/` on Unix contains all hook repos, one is the one for lorenzwalthert/precommit hooks that contains a {renv} somehow nested. Make your life easier with `pre-commit clean` your...

Well if you want to override dependencies specified in `renv.lock` from lorenzwalthert/precommit, just use `additional_dependencies` in `.pre-commit-config.yaml`: ```yaml - id: lintr additional_dependencies: - [email protected] ```

@joelnitta do you want to implement the {cff} hook in the spirit of the {codemeta} hook? I won't have time to do that.

Great. You can also see other PRs that added hooks, e.g. the recent #393 or maybe more relevant the #350.