Logan Collins

Results 32 comments of Logan Collins

A quick search does not yield promising results for libraries providing unicode equivalence functions. The 'best' option might be https://crates.io/crates/unicode-normalization and then compare instead. unsure if segmentation is required at...

Love it, I was gunna add something just like this. :) I will probably review this more thoroughly Tuesday. This weekend is busy for me. Two thoughts: 1) `Match` is...

The conflict I have in mind is that 'Match', or something like it, is a more appropriate name for a type used by `util::find_longest_match`. The problem with programming principles is...

Admittedly, in `utils`, `MatchingSequence` is probably more appropriate. Still, for `process`, `QueryScore` or just `Score` is more accurate as we're not really doing any matching.

I don't know how this interacts with the other PRs but it seems fine for now. We'll deal with merging later. :D

They both have merit. I've never liked the process methods haha

`wratio` -> `wratio` and `wratio_calc` like `ratio_full` and `simple_calc` same with `partial_ratio_full` for that matter

basically the current impl of extract_without_order doesn't double call the processors, but if the *scorer* calls processing, you're hosed. It just so happens the original scorers by default do because...

not quite, no. You have things like `ratio_full` which does processor and delegates to `simple_ratio` which could be considered a scorer, but that structure is not applied to, say, `partial_ratio_full`...

Example of a random python Smith-Waterman alignment: ``` >>> sw.align("what about supergreatfantastic theatre", "superduperfantastic theater about what").dump() Query: 1 superdupe-rfantastic theater 27 ||||| ..| .||||||||||||||| | Ref : 12 super-greatfantastic...