Lily Wang

Results 154 comments of Lily Wang
trafficstars

Thanks for the thoughtful and comprehensive review, @ppillot! The roadmap you suggested looks great and practical. Unfortunately it has been a while since I looked at NGLViewer or Javascript in...

Yes and no -- @ojeda-e put a lot of amazing work into fixing up all our references and making sure everything was neatly bibtex that would be a great pity...

@HeetVekariya you've got the string part of it very close! The overall issue here is that TopologyAttrs can have different types (which is set by the `dtype` property of each...

> Sorry for asking question like this without creating PR No worries @HeetVekariya, it's better to have a clear approach and know what you want to do before creating PRs!...

@HeetVekariya the reason I bring up `set_atoms`, `set_residues`, etc. -- this issue is about *all* TopologyAttrs defined in topologyattrs.py. Not all of them subclass `_StringInternerMixin` and not all of them...

@HeetVekariya yes sure, go ahead.

Spitballing: you could do some metaclass hackery for this. I haven't thought through if the added complexity is worth it. ```python class BaseSchemaMeta(ModelMetaclass): registry = [] def __init__(self, name, *args,...

Yes sure please do, rounding seems like the best solution here.